Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CDF-23165] 😳Regression fix #1212

Merged
merged 5 commits into from
Nov 19, 2024
Merged

[CDF-23165] 😳Regression fix #1212

merged 5 commits into from
Nov 19, 2024
+2 −2

Conversation

doctrino
Copy link
Collaborator

Description

This is a regression

Before

image

After

image

Checklist

@doctrino doctrino requested a review from a team as a code owner November 18, 2024 19:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 18, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13628 10183 75% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite_toolkit/_cdf_tk/commands/build.py 82% 🟢
TOTAL 82% 🟢

updated for commit: 9e04aa4 by action🐍

ronpal
ronpal approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@ronpal ronpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from skip-copy-file-to-build-folder to main November 19, 2024 08:16
@doctrino doctrino merged commit 9fe1e85 into main Nov 19, 2024
10 checks passed
@doctrino doctrino deleted the nice-warnings branch November 19, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronpal ronpal ronpal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doctrino @ronpal